[pmg-devel] applied: [PATCH] SpamQuarantine: simplify download button by binding its href config

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 25 12:29:36 CEST 2019


On 10/25/19 12:28 PM, Thomas Lamprecht wrote:
> This avoids all the strange click event hack. We already have a
> button where the users needs to click on, so just use that.
> 
> A viewModel with a downloadMailURL formula to assemble the href
> allows us to just bind the "href" config from the Download button,
> and be done with it..
> 
> refactors commit 7ad0de10d630f628b15969ef1478b9276e46197b
> 
> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
> 
> I've no idea why commit 7ad0de10d630f628b15969ef1478b9276e46197b went this
> complicated and seemingly hacky route, the commit message isn't really
> telling... So if there were any real reasons this was done this complicated
> way: please holler me, I saw none..
> 

forgot: already applied.



More information about the pmg-devel mailing list