[pmg-devel] [PATCH http-server/api/gui/docs v3] add attachment quarantine

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 17 16:10:10 CEST 2019


On 10/11/19 2:08 PM, Stoiko Ivanov wrote:
> Compared the v3 with the v2 - looks good!
> Tested some more and with a bit more detail - From my point of view it works
> well!
> 
> Thanks for implementing this!
> 
> Reviewed-By: Stoiko Ivanov <s.ivanov at proxmox.com>
> Tested-By: Stoiko Ivanov <s.ivanov at proxmox.com>
> 

applied all pmg-api related patches where I not replied explicitly
with your R-b and T-b tags, done with:
# git filter-branch --msg-filter 'git interpret-trailers --trailer "Reviewed-By: Stoiko Ivanov <s.ivanov at proxmox.com>" --trailer "Tested-By: Stoiko Ivanov <s.ivanov at proxmox.com>"' origin/master..
gotta love git :)

> On Thu, 10 Oct 2019 12:12:33 +0200
> Dominik Csapak <d.csapak at proxmox.com> wrote:
> 
>> On 10/10/19 11:21 AM, Dominik Csapak wrote:
>>> this series adds a new type of quarantine: 'attachment'
>>>
>>> on 'Remove' actions, an admin can now copy the mail into the
>>> attachment quarantine, while the mail with the removed attachment
>>> will be sent to the recipient. now the admin can retrieve
>>> the removed attachments, send it verbatim, or remove it
>>>
>>> pmg-api patches 2-5 are general refactors, and could be applied
>>> independently (although the later patches depend on them)
>>>
>>> pmg-api patch 6,7 are improvements/fixes and only
>>> tangentially related (mostly touch the same files)
>>>   
>>
>> this part of the cover letter is slightly wrong, since patch 6 from v2
>> got applied, so this only is valid for the patch (now) numbered 6 (7 in v2)



More information about the pmg-devel mailing list