[pmg-devel] [PATCH pmg-gui] fix 1652: rename NDR to empty senders in GUI

[Stoiko Ivanov]

Any opinions on this cosmetic patch? apart from the commit message:
On Thu, Oct 10, 2019 at 07:20:22PM +0200, Stoiko Ivanov wrote:
> Bug 1652 indicates a slight misalignment of our use of NDR with the
> expectations users might have:
> We use it throughout our codebase meaning - mails with empty senders (NDRs
> a.k.a bounces do most often have an empty sender (to prevent mailloops) but
> quite a few messages being directly non-delivery-notifications also use an
> empty sender (since noone would be reading the automated bounces for them) -
> e.g. our quarantine report)
a bit awkward phrasing - maybe:
We use it throughout our codebase meaning - mails with empty senders.
NDRs do have empty senders (to prevent mailloops), but so do other messages
- e.g. our quarantine report

> 
> By renaming the GUI-display field it should be more clear to users of the
> Tracking center.
> 
> The fix is left at the GUI-level, since the use of ndr for empty sender is
> quite consistent throughout our complete stack (in that case from the GUI, via
> pmg-api down to the pmg-log-tracker) and I don't see the direct benefit for
> renaming it everywhere (and am lacking a better concise phrase for "empty
> envelope sender").
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  js/MailTracker.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/js/MailTracker.js b/js/MailTracker.js
> index 9cf9fa4..67ad371 100644
> --- a/js/MailTracker.js
> +++ b/js/MailTracker.js
> @@ -123,7 +123,7 @@ Ext.define('PMG.MailTrackerFilter', {
>  		    border: false,
>  		    items: [
>  			{
> -			    boxLabel: gettext('Include NDRs'),
> +			    boxLabel: gettext('Include Empty Senders'),
>  			    xtype: 'proxmoxcheckbox',
>  			    listeners: { change: 'onFilterChange' },
>  			    reference: 'ndr',
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel at pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
>