[pmg-devel] [PATCH pmg-log-tracker] rewrite in rust

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 5 15:26:38 CET 2019


On 11/5/19 3:21 PM, Mira Limbeck wrote:
> pmg-log-tracker has been rewritten in Rust. Functionality is the same.
> Output sometimes has a different order than the pmg-log-tracker in C.
> This only happens when the time of the entries is equal.
> 
> There's one change regarding the interface. In addition to the short
> versions of arguments also long versions exist.
> 
> The implementation uses Rc<> and RefCell<> to make holding mutable
> cross-references possible, without having to change the original logic
> completely. This allowed for easier translation from C to Rust.
> 
> The file debian/cargo-checksum.json is required by dh-cargo, otherwise
> it won't compile. The cargo-checksum.json should contain the upstream
> .crate file which does not exist in this case, so we just create an
> empty one with the required keys. (see 'Library package structure' in
> https://wiki.debian.org/Teams/RustPackaging/Policy)
> 
> The change to the minimum version of debhelper required was done
> according to other rust packages (rust-clap, rust-bindgen, rust-ripgrep).
> 
> Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
> ---
> Regarding the version, how do you want to handle it? Keep the Cargo.toml
> version in sync with the package version (major, minor)?
> 
> This already contains the changes @Wolfgang recommended, simplifying a
> lot of code, especially the printing. Also got rid of one RefCell and
> one Cell usage, as we can now pass the Parser as mutable reference to
> both print() functions.

any benchmark to share?



More information about the pmg-devel mailing list