[pmg-devel] [PATCH pmg-gui 1/1] fix #2504: add checkbox for overwriting selectors

[Dominik Csapak]

one comment inline

On 12/5/19 2:01 PM, Stoiko Ivanov wrote:
> Add a checkbox with descriptive label for the force parameter of
> config/dkim/selector.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>   js/DKIMSettings.js | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
> index a92a033..89dc807 100644
> --- a/js/DKIMSettings.js
> +++ b/js/DKIMSettings.js
> @@ -149,6 +149,14 @@ Ext.define('PMG.DKIMSettings', {
>   			    ['4096', '4096'],
>   			    ['8192', '8192']
>   			]
> +		    },
> +		    {
> +			xtype: 'proxmoxcheckbox',
> +			name: 'force',
> +			uncheckedValue: 0,
> +			defaultValue: 0,
> +			checked: false,

those 3 lines should be unecessary:

uncheckedValue can be ok, but is not needed,
since the parameter is optional

defaultValue makes only sense in combination
with deleteDefaultValue for configs

and checked defaults to false anyway

> +			fieldLabel: gettext('Overwrite existing file'),
>   		    }
>   		]
>   	    }
>