[pmg-devel] [PATCH pmg-api/pmg-gui] better handling of existing DKIM selector files

Stoiko Ivanov s.ivanov at proxmox.com
Thu Dec 5 14:01:41 CET 2019

This patchset addresses https://bugzilla.proxmox.com/show_bug.cgi?id=2504 .
Since simply overwriting an existing private key can lead to a rather long
interruption for working DKIM signatures (overwriting an existing selector,
for which many domains already have a DNS-record, means you need to replace
all those records and wait for DNS-TTLs) we should prevent users from doing
so without explicitly choosing it.

The sanity checks for existing files (does it contain an RSA key and does it
have the provided size) are inspired by Dominik - thanks!

The issue was initially brought up in the support forum:

Stoiko Ivanov (1):
  fix #2504: do not overwrite existing selector key

 src/PMG/API2/DKIMSign.pm |  7 ++++++-
 src/PMG/DKIMSign.pm      | 23 ++++++++++++++++++-----
 2 files changed, 24 insertions(+), 6 deletions(-)

Stoiko Ivanov (1):
  fix #2504: add checkbox for overwriting selectors

 js/DKIMSettings.js | 8 ++++++++
 1 file changed, 8 insertions(+)


More information about the pmg-devel mailing list