[pdm-devel] [PATCH datacenter-manager/proxmox v2 0/6] pbs client: fix PBS version 3 login ticket parsing compatibility

[Thomas Lamprecht]

Am 30.09.25 um 14:19 schrieb Christian Ebner:
> On 9/30/25 1:49 PM, Wolfgang Bumiller wrote:
>> On Tue, Sep 30, 2025 at 10:02:01AM +0200, Christian Ebner wrote:
>>> This patches fix the ticket parsing when login to instances of PBS version 3
>>> or lower. For this, the current pve_compat flags for `Login` and `Client`
>>> are refactored to be an extendable enum variant instead, adding the ticket
>>> parsing backwards compatibility. In that compatibility mode, response parsing
>>> of the ticket does not interpret the presence of the `ticket-info` field as the
>>> ticket being a `http-only` ticket and fallsback to the PBS version 3 and 4
>>> compatible parsing, as the client never used `http-only` tickets.
>>
>> I thought this field was introduced only with http-only tickets, so why
>> is it not a reliable indicator and shouldn't *that* be fixed instead?
> 
> I'm not so familiar with the actual code and the changes over time here, so that might as well be the case.

FYI: Shannon is back at work tomorrow and this is not really _that_
pressing, so I'd wait at least until tomorrow to hopefully get some
better rationale.