[pdm-devel] [PATCH datacenter-manager 1/4] ui: pve: storage: clippy fix

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Sep 26 12:47:57 CEST 2025


On Fri, 26 Sep 2025 09:20:05 +0200, Dominik Csapak wrote:
> unnecessary reference, after we remove that, it's an unnecessary closure
> 
> 

Applied, thanks!

I reworded the commit message though, as especially the one from patch 3/4 was
misleading (fixes status update not rrd update). Also made a follow-up to
change the name of the timeout update reference guards to not start with an
underscore, as then we would have noticed this earlier.
We should avoud rework other code sides using this problematic pattern too, not
sure if the "_guard" prefix is the best one ("_holder" might be an
alternative), but it's semantically true enough and we can change that still.

[1/4] ui: pve: storage: clippy fix
      commit: cf90529e6d250dd4113db3884efc8ce46c02699c
[2/4] ui: pve: storage: remove unnecessary import
      commit: f8c9d3db5cd51dfff92384379f764a0710c29ab7
[3/4] ui: pve: storage: fix rrd update
      commit: c515d324ba077625b0f15ccf08c878bc97fdb12e
[4/4] ui: pve: storage: remove unnecessary 'enabled' status line
      commit: e8be46072ead4e53dd3cec04bc26ed90642dcffd




More information about the pdm-devel mailing list