[pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 00/11] Add LDAP and AD realm support to Proxmox Datacenter Manager

[Shannon Sterz]

one more thing:

On Fri Sep 19, 2025 at 1:11 PM CEST, Shannon Sterz wrote:
> On Fri Sep 19, 2025 at 12:02 PM CEST, Christoph Heiss wrote:

-->8 snip 8<--

>> - PVE/PBS have the ability to also sync the `comment` field from some
>>   attribute (e.g. `sync-attributes comment=userPrincipal`), for PDM
>>   this currently is not allowed by the schema. But this can be part of a
>>   future improvement IMO.
>
> will take a look at this as well, must have missed that as it wasn't
> exposed in the ui.

did that now, but this is not actually something pbs supports. looking
at the sync logic [1] comments are only preserved, not synced from the
realm.

the SyncAttributes schema also does not have a `Comment` variant [2].
so i think for now getting the existing logic into a common crate takes
precedence over implementing feature parity with pve imo. meaning, i'll
leave this as a follow up.

[1]: https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=src/server/realm_sync_job.rs;h=8768a0d80fcfda10dc7e1549592556b1ccc6f347;hb=HEAD#l295
[2]: https://git.proxmox.com/?p=proxmox.git;a=blob;f=pbs-api-types/src/ldap.rs;h=5114616055bca1e032c4222cff8b0047ca6bb514;hb=HEAD#l180