[pdm-devel] [PATCH network/proxmox{, -backup, -api-types, -datacenter-manager} v2 00/30] Add initial SDN / EVPN integration

[Dominik Csapak]

On 9/2/25 2:03 PM, Stefan Hanreich wrote:
> On 9/2/25 1:10 PM, Dominik Csapak wrote:
>> setup a few remotes created a few zones/vnets, series tested mostly fine
>> (did not do too extensive testing though)
>>
>> noticed one thing that can probably be improved (i think on the pve
>> side?): when i try to create e.g. a vnet with an id that already exists
>>
>> i get
>> ---8<---
>> 2025-09-02T13:04:14+02:00: failed to execute transaction on remote pve-
>> ceph-cluster: api error (status = 500: create sdn vnet object failed:
>> sdn vnet object ID 'foo' already defined
>> )
>> 2025-09-02T13:04:14+02:00: could not rollback and unlock configuration
>> for remote pve-ceph-cluster - configuration needs to be manually
>> unlocked via 'pvesh delete /cluster/sdn/lock --force 1'
>> --->8---
>>
>> two things here:
>> * there is a stray newline in the error message
>> * detecting duplicates should already be detected before applying
>>    and we should be able to roll them back?
> 
> is it possible that this remote doesn't have the pve-network patches
> that add the return statement? Without them the issue is that the
> rollback on PVE side happens, but the response from the PVE side cannot
> be parsed (since it doesnt fit the JSONSchema defined there) and
> therefore leads to this error. We might be able to work around by this
> overriding the auto-generated Rust types in generate.pl as well, but
> that seemed suboptimal as well.

ah yes you're right, with new pve-network on that remote it works


the question remains if we want to gracefully handle
older versions too... but for now it's fine i think