[pdm-devel] [PATCH datacenter-manager v2 13/13] remote updates: avoid unnecessary clone

Lukas Wagner l.wagner at proxmox.com
Fri Oct 17 14:10:09 CEST 2025


Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---

Notes:
    New in v2

 server/src/api/remote_updates.rs | 2 +-
 server/src/remote_updates.rs     | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/server/src/api/remote_updates.rs b/server/src/api/remote_updates.rs
index c1309432..bea2d864 100644
--- a/server/src/api/remote_updates.rs
+++ b/server/src/api/remote_updates.rs
@@ -201,7 +201,7 @@ async fn apt_get_changelog(
     let (config, _digest) = pdm_config::remotes::config()?;
     let remote = get_remote(&config, &remote)?;
 
-    remote_updates::get_changelog(remote.clone(), &node, options.name).await
+    remote_updates::get_changelog(remote, &node, options.name).await
 }
 
 const APT_SUBDIRS: SubdirMap = &[
diff --git a/server/src/remote_updates.rs b/server/src/remote_updates.rs
index 4c70495b..87c6afd9 100644
--- a/server/src/remote_updates.rs
+++ b/server/src/remote_updates.rs
@@ -83,10 +83,10 @@ pub async fn update_apt_database(remote: &Remote, node: &str) -> Result<RemoteUp
 }
 
 /// Get the changelog for a given package.
-pub async fn get_changelog(remote: Remote, node: &str, package: String) -> Result<String, Error> {
+pub async fn get_changelog(remote: &Remote, node: &str, package: String) -> Result<String, Error> {
     match remote.ty {
         RemoteType::Pve => {
-            let client = connection::make_pve_client(&remote)?;
+            let client = connection::make_pve_client(remote)?;
 
             client
                 .get_package_changelog(node, package, None)
@@ -94,7 +94,7 @@ pub async fn get_changelog(remote: Remote, node: &str, package: String) -> Resul
                 .map_err(Into::into)
         }
         RemoteType::Pbs => {
-            let client = connection::make_pbs_client(&remote)?;
+            let client = connection::make_pbs_client(remote)?;
 
             client
                 .get_package_changelog(package, None)
-- 
2.47.3





More information about the pdm-devel mailing list