[pdm-devel] [PATCH datacenter-manager 4/4] ui: qemu: remove wrong PartialEq implementation

Dietmar Maurer dietmar at proxmox.com
Wed Oct 15 10:15:24 CEST 2025


i.e. we want to update the view on cpu property changes.

Signed-off-by: Dietmar Maurer <dietmar at proxmox.com>
---
 ui/src/pve/qemu/overview.rs | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/ui/src/pve/qemu/overview.rs b/ui/src/pve/qemu/overview.rs
index 62efbae..3d715eb 100644
--- a/ui/src/pve/qemu/overview.rs
+++ b/ui/src/pve/qemu/overview.rs
@@ -17,7 +17,7 @@ use pdm_client::types::{IsRunning, QemuStatus};
 
 use crate::renderer::{separator, status_row};
 
-#[derive(Clone, Debug, Properties)]
+#[derive(Clone, Debug, Properties, PartialEq)]
 pub struct QemuOverviewPanel {
     remote: String,
     node: String,
@@ -32,20 +32,6 @@ pub struct QemuOverviewPanel {
     pub status_interval: u32,
 }
 
-impl PartialEq for QemuOverviewPanel {
-    fn eq(&self, other: &Self) -> bool {
-        if self.remote == other.remote && self.node == other.node {
-            // only check some fields, so we don't update when e.g. only the cpu changes
-            self.info.name == other.info.name
-                && self.info.id == other.info.id
-                && self.info.node == other.node
-        } else {
-            false
-        }
-    }
-}
-impl Eq for QemuOverviewPanel {}
-
 impl QemuOverviewPanel {
     pub fn new(remote: String, node: String, info: PveQemuResource) -> Self {
         yew::props!(Self { remote, node, info })
-- 
2.47.3




More information about the pdm-devel mailing list