[pdm-devel] Superseded: Re: [PATCH datacenter-manager/proxmox/yew-comp 0/8] add better token support for pdm

[Shannon Sterz]

On Fri Oct 3, 2025 at 4:21 PM CEST, Shannon Sterz wrote:
> this series aims to add a ui to the pre-existing token support in pdm.
> it also aims to get it more in-line with what other proxmox products
> provide in terms of functionality.
>
> the first two patches prepaer proxmox-access-control by refactoring it a
> little bit. the next commit adds api endpoints for handling tokens.
> these api endpoints are intentionally not providing any access control
> permissions, so that users of this crate can set them themselves.
>
> the next two commits improve the token panel in proxmox-yew-comp by
> using the Clipboard API when copying values. the layout and
> functionality of the dialog displaying the token secret is also
> improved.
>
> the final three patches integrate the token panel in pdm's ui. they also
> refactor the api endpoints related token handling to use the new
> endpoints from proxmxo-access-control and make sure the user delete
> endpoint cleans up acls and tokens too.
>
> Changelog
> ---------
>
> changes since rfc:
> - the commits implementing the basic token panel have already been
>   applied by Thomas Lamprecht, thanks!
> - moved adding `use` and `mod` statements for the token module to the
>   right commit in the series (thanks @ Dominik Csapak)
> - generate token secrets in the `token_shadow` module instead of in the
>   token endpoints themselves (thanks @ Fabian Grünbichler)
> - use a schema for the `regenerate` parameter of the update token
>   endpoint (thanks @ Fabian Grünbichler)
> - allow deleting comments via a `delete` property (thanks @ Fabian
>   Grünbichler)
> - make the token delete endpoint clean up token acls (thanks @ Fabian
>   Grünbichler)
> - improve copy to clipboard functionality to use the new Clipboard API
> - improve the layout of the token secret dialog (thanks @ Thomas
>   Lamprecht)
>
>
> proxmox:
>
> Shannon Sterz (3):
>   access-control: refactor api module to be more hirachical
>   access-control: move `ApiTokenSecret` to types module
>   access-control: add api endpoints for handling tokens
>
>  proxmox-access-control/Cargo.toml             |   1 +
>  .../src/{api.rs => api/acl.rs}                |   0
>  proxmox-access-control/src/api/mod.rs         |   8 +
>  proxmox-access-control/src/api/tokens.rs      | 310 ++++++++++++++++++
>  proxmox-access-control/src/token_shadow.rs    |  17 +-
>  proxmox-access-control/src/types.rs           |  43 ++-
>  6 files changed, 369 insertions(+), 10 deletions(-)
>  rename proxmox-access-control/src/{api.rs => api/acl.rs} (100%)
>  create mode 100644 proxmox-access-control/src/api/mod.rs
>  create mode 100644 proxmox-access-control/src/api/tokens.rs
>
>
> proxmox-yew-comp:
>
> Shannon Sterz (2):
>   utils/tfa add recover/token panel: add copy_text_to_clipboard function
>   token panel: improve token secret dialog layout and hide password
>
>  Cargo.toml                  |   2 +
>  src/tfa/tfa_add_recovery.rs |  17 ++----
>  src/token_panel.rs          | 117 ++++++++++++++++++------------------
>  src/utils.rs                |  22 +++++++
>  4 files changed, 89 insertions(+), 69 deletions(-)
>
>
> proxmox-datacenter-manager:
>
> Shannon Sterz (3):
>   ui: add a token panel and a token acl edit menu in the permissions
>     panel
>   server: access: use token endpoints from proxmox-access-control
>   server: clean up acl tree entries and api tokens when deleting users
>
>  server/src/api/access/users.rs | 388 ++++++---------------------------
>  ui/src/configuration/mod.rs    |  33 ++-
>  2 files changed, 95 insertions(+), 326 deletions(-)
>
>
> Summary over all repositories:
>   12 files changed, 553 insertions(+), 405 deletions(-)
>
> --
> Generated by git-murpp 0.8.1

Superseded-by: https://lore.proxmox.com/all/20251014143709.413690-1-s.sterz@proxmox.com/T/#t