[pdm-devel] [PATCH datacenter-manager 5/7] ui: dashboard: distinguish failed remotes based on remote type

[Dominik Csapak]

On 10/14/25 11:19 AM, Christian Ebner wrote:
> On 10/14/25 10:47 AM, Dominik Csapak wrote:
>> more of a high level comment regarding the node dashboard component, but
>> it fits here as well as the previous patch:
>>
>> i believe we should rethink how we propagate the information
>> to this panel, so that we don't have to extract the correct information
>> inside
>>
>> e.g. either we restructure the api call/data in a way to separate
>> the info by type in the first place, or we do that directly
>> after the api call.
>>
>> either way I'd probably give this panel just a simple struct
>> with the necessary information to display
>>
>> I think this would make it a bit easier to follow and less
>> like that we forget to e.g. check the type for the content
>>
>> what do you say?
> 
> Yes, agreed. Will keep the panel input data as simple as possible then.
> 
> 
> Fetching the status by remote type would be an option, but at the cost 
> of an additional API call. Also the return data is already laid out to 
> be cumulative over remote type variants.

i'd like to avoid more api calls if possible/sensible

> 
> Therefore, maybe better to do the splitting of the remote type specific 
> information after getting the status?

sound good to me

> 
> Finally, splitting the `status` endpoint return data by type is nor 
> really an option, since that would be a breaking API change, so better 
> avoided.

since we're still in beta, this is not that much of a concern though

> 
> Thanks a lot for your comments!