[pdm-devel] [PATCH datacenter-manager] server: fake remotes: adapt to changed ClientFactory trait

[Dominik Csapak]

On 5/14/25 09:49, Lukas Wagner wrote:
> On  2025-05-14 09:30, Dominik Csapak wrote:
>> On 5/13/25 15:25, Lukas Wagner wrote:
>>> For the record, I already sent a patch for this in a previous patch series.
>>>
>>> https://lore.proxmox.com/pdm-devel/20250418083210.74982-6-l.wagner@proxmox.com/T/#u
>>>
>>
>> yes, i noticed just before you sent this mail (see my other response, that weirdly
>> only contains a html part....)
>>
>> but good to see that we basically have sent the same diff ^^
>>
>> also, would it make sense to extend the fake remote part?
>>
>> 3 improvements i noticed that would be nice imho
>> * simulate more api calls
>> * fix some values (e.g. maxdisk is smaller than disk for hosts)
>> * add some pseudo random dynamic values? so that it changes over time a bit (e.g. via a configurable jitter percentage)
>>    this would be nice to fully test the ui without having to setup multiple test clusters
>>
> 
> Sure, makes sense. Feel free to send some patches, otherwise I can have a go at it
> when I have the time. The stuff that I already implemented mostly served my own development
> needs, for sure there are things missing for other areas of the system.
> 
> Another thing that I would like to add is to have a simple way to switch between
> multiple fake "profiles" (e.g. different PDM setups sizes, tiny, medium, huge) so
> that it is easier to do performance testing in a standardized way. Already
> talked to Thomas about this, he provided me some of the variables for these profiles (e.g.
> number of remotes, guests per remote, etc.) - but haven't had the time yet to integrate that.
> 

sure, I'll send patches for that. I noticed already that in some areas the UI is
not optimal to use when getting to certain large numbers (mostly layout issues, not performance)

so it'll be good to have for ui testing too

as for different profiles, for the short term it could be enough to check in sample
json files into the git repository together with the documentation.

then it'd be a simply copy & restart

(e.g. i have setup my systemd services to provide the ENV variable)