From t.lamprecht at proxmox.com  Tue Jul  1 11:41:47 2025
From: t.lamprecht at proxmox.com (Thomas Lamprecht)
Date: Tue,  1 Jul 2025 11:41:47 +0200
Subject: [pdm-devel] applied: [PATCH datacenter-manager] cli: fix adding
 remotes
In-Reply-To: <20250616135804.3212548-1-d.csapak@proxmox.com>
References: <20250616135804.3212548-1-d.csapak@proxmox.com>
Message-ID: <175136290290.4025787.4400514774616596334.b4-ty@proxmox.com>

On Mon, 16 Jun 2025 15:58:04 +0200, Dominik Csapak wrote:
> three things needed fixing here:
> * type is already included in the remote type, so no need to have it
>   externally
> * the api call uses `async` so change the handler matching
> * the api call needs the proxmox_product_config to be initialized
> 
> noticed by a user in the forum:
> https://forum.proxmox.com/threads/167483/
> 
> [...]

Applied, thanks!

[1/1] cli: fix adding remotes
      commit: a250bc6b054548994cf2d7c169579c6ce0bfc6f7



From l.wagner at proxmox.com  Tue Jul  1 12:02:44 2025
From: l.wagner at proxmox.com (Lukas Wagner)
Date: Tue, 1 Jul 2025 12:02:44 +0200
Subject: [pdm-devel] [PATCH proxmox-datacenter-manager v5 1/6] remote
 tasks: implement improved cache for remote tasks
In-Reply-To: <1df410bd-badc-45db-8a9e-a1292d8532d5@proxmox.com>
References: <20250512114144.118545-1-l.wagner@proxmox.com>
 <20250512114144.118545-2-l.wagner@proxmox.com>
 <1df410bd-badc-45db-8a9e-a1292d8532d5@proxmox.com>
Message-ID: <41d1b3fa-e348-455f-9a98-c60180044d6a@proxmox.com>



On  2025-05-14 16:08, Dominik Csapak wrote:
> Just started to review the series, and wanted to say that
> I'll give some early feedback on this one before diving into the
> others.
> 
> (sorry if i mention something that was already mentioned in a previous
> iteration, just throw it back to me should that happen ;) )
> 
> On a high level: Looks mostly good to me, besides a few smaller things inline
> and the following:
> 

Thanks a lot for the review and sorry for the long wait. I didn't really keep a close eye on the
pdm-devel list in the last few weeks because I was busy with other stuff relevant to the upcoming
major releases. I also only saw your replies a couple days ago since I was not in CC (CC'd mails land
directly in my inbox vs the pdm-devel folder, where Thunderbird makes it not really easy to see
new messages in collapsed threads).

I'll answer with some more detail soon, I have to think through your suggestions and also brush up
my own memories about my approach/code.


Thanks!

-- 
- Lukas