[pdm-devel] [PATCH proxmox-datacenter-manager 14/15] remote tasks: fix unused variable warning

Lukas Wagner l.wagner at proxmox.com
Tue Jan 28 13:25:19 CET 2025


Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
 server/src/remote_tasks/mod.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/server/src/remote_tasks/mod.rs b/server/src/remote_tasks/mod.rs
index 171c8aa..5735f2f 100644
--- a/server/src/remote_tasks/mod.rs
+++ b/server/src/remote_tasks/mod.rs
@@ -69,8 +69,10 @@ pub async fn get_tasks(
                 Ok(tasks) => {
                     cache.add_tasks(remote_name.as_str(), tasks, now);
                 }
-                Err(err) => {
-                    // ignore errors for not reachable remotes
+                Err(_err) => {
+                    // TODO: Log warning if a remote's tasks could not be fetched.
+                    // TODO: Add a mechanism to log not too often - we need that in other places as
+                    // well, so maybe come up with something generic.
                     continue;
                 }
             }
-- 
2.39.5





More information about the pdm-devel mailing list