[pdm-devel] [RFC pdm v2] ui: make layout more consistent using new ContentSpacer widget

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jan 15 16:48:41 CET 2025


Am 10.01.25 um 13:50 schrieb Dietmar Maurer:
> Signed-off-by: Dietmar Maurer <dietmar at proxmox.com>
> ---
> 
>  Changhes in v2:
>  - use box shadows instead of border
>  - use ContentSpacer for dashboard
>  - use ContentSpacer for PveRemote
> 
>  ui/css/crisp-yew-style.scss            | 12 ++++
>  ui/css/desktop-yew-style.scss          | 11 +++
>  ui/css/pdm.scss                        | 26 ++++++-
>  ui/src/administration/mod.rs           | 28 ++++++--
>  ui/src/certificates.rs                 | 30 ++++++--
>  ui/src/configuration/mod.rs            | 25 ++++---
>  ui/src/configuration/other/mod.rs      |  9 ++-
>  ui/src/configuration/other/webauthn.rs |  1 -
>  ui/src/dashboard/mod.rs                | 17 +++--
>  ui/src/main_menu.rs                    | 22 +++---
>  ui/src/pve/mod.rs                      |  7 +-
>  ui/src/widget/content_spacer.rs        | 99 ++++++++++++++++++++++++++
>  ui/src/widget/mod.rs                   |  3 +
>  13 files changed, 242 insertions(+), 48 deletions(-)
>  create mode 100644 ui/src/widget/content_spacer.rs

This was seemingly applied now by yourself? I saw no review on the list, did I
miss it?

The configuration, syslog, ... panels look quite odd now, it's a bit hard to
tell if that is wanted as there is no commit message describing the whats and
whys..

So I'd revert this again?




More information about the pdm-devel mailing list