[pdm-devel] [PATCH datacenter-manager 1/5] server: add an optional 'web-url' property for remotes

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jan 15 16:12:22 CET 2025


Am 10.01.25 um 11:21 schrieb Dominik Csapak:
> this contains two optional values to generate a URL for the UI:
> * per_node_template: a 'per node' template to generate an url, used for
>   all places where we have node information. If not set we use the
>   base_url as fallback to generate the url.
> 
> * base_url: An URL for reaching the remote. This is e.g. useful if there
>   is some reverse proxy or similar between the users browser and the
>   remote.

Why two, and not just one? And why was this already applied without
any comment/review from people in the discussion of that feature?

The unrelated fixes would be also nice as separate patches, or at
least upfront – as quite often stated already to all devs..




More information about the pdm-devel mailing list