[pdm-devel] [PATCH proxmox-yew-comp 06/15] use any() instead of find and is_none combination
Maximiliano Sandoval
m.sandoval at proxmox.com
Mon Jan 13 15:27:16 CET 2025
Fixes:
warning: called `is_none()` after searching an `Iterator` with `find`
--> src/apt_repositories.rs:282:8
|
282 | if list.iter().find(|l| l.status != Status::Ok).is_none() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `!list.iter().any(|l| l.status != Status::Ok)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
src/apt_repositories.rs | 2 +-
src/configuration/network_view.rs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/apt_repositories.rs b/src/apt_repositories.rs
index 365e01b..2998a5a 100644
--- a/src/apt_repositories.rs
+++ b/src/apt_repositories.rs
@@ -276,7 +276,7 @@ fn update_status_store(
)));
}
- if list.iter().find(|l| l.status != Status::Ok).is_none() {
+ if !list.iter().any(|l| l.status != Status::Ok) {
list.push(StatusLine::ok(tr!(
"All OK, you have production-ready repositories configured!"
)));
diff --git a/src/configuration/network_view.rs b/src/configuration/network_view.rs
index c56d97c..4666b64 100644
--- a/src/configuration/network_view.rs
+++ b/src/configuration/network_view.rs
@@ -97,7 +97,7 @@ impl ProxmoxNetworkView {
fn find_next_free_interface_id(prefix: &str, list: &[Interface]) -> Option<String> {
for next in 0..9999 {
let id = format!("{prefix}{next}");
- if list.iter().find(|item| item.name == id).is_none() {
+ if !list.iter().any(|item| item.name == id) {
return Some(id);
}
}
--
2.39.5
More information about the pdm-devel
mailing list