[pdm-devel] [PATCH proxmox-yew-comp 14/15] use cloned() instead of explicit clone() in closure

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Jan 13 15:27:24 CET 2025


Fixes:

warning: you are using an explicit closure for cloning elements
  --> src/configuration/network_view.rs:91:31
   |
91 |             selected_record = self.store.read().lookup_record(key).map(|r| r.clone());
   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.store.read().lookup_record(key).cloned()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
   = note: `#[warn(clippy::map_clone)]` on by default

Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
 src/configuration/network_view.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/configuration/network_view.rs b/src/configuration/network_view.rs
index 5dd0acf..20ad5d0 100644
--- a/src/configuration/network_view.rs
+++ b/src/configuration/network_view.rs
@@ -88,7 +88,7 @@ impl ProxmoxNetworkView {
         let selected_key = self.selection.selected_key();
         let mut selected_record = None;
         if let Some(key) = &selected_key {
-            selected_record = self.store.read().lookup_record(key).map(|r| r.clone());
+            selected_record = self.store.read().lookup_record(key).cloned();
         }
         selected_record
     }
-- 
2.39.5





More information about the pdm-devel mailing list