[pdm-devel] [PATCH proxmox-datacenter-manager 25/25] cli: add commands for metric-collection settings, trigger, status

[Lukas Wagner]

On  2025-02-13 15:56, Wolfgang Bumiller wrote:
>>>> +
>>>> +pub fn cli() -> CommandLineInterface {
>>>> +    CliCommandMap::new()
>>>> +        .insert(
>>>> +            "show-settings",
>>>> +            CliCommand::new(&API_METHOD_SHOW_COLLECTION_SETTINGS),
>>>> +        )
>>>
>>> ↑↓ wouldn't `settings show`, `settings update` be more consistent?
>>>
>>>> +        .insert(
>>>> +            "update-settings",
>>>> +            CliCommand::new(&API_METHOD_UPDATE_COLLECTION_SETTINGS),
>>>> +        )
>>
>> I see your point, but then a 'show' next to a 'status' also felt a bit weird, that
>> was the reason why I added the suffix to make it more clear. I can change it back
>> if you prefer.
> 
> Well, it's a "settings show", not a "show settings", next to the
> "status", as in, the show is on a different level, or what do you mean?

Oh, right, that's better. I'll do it that way then.

Thx!

-- 
- Lukas