[pdm-devel] [PATCH proxmox-datacenter-manager 0/7] clippy fixes for 1.90

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Dec 29 17:18:35 CET 2025


This was spotted with clippy 0.1.90 and rustc 1.90.

After this, there is only one renaming clippy lint after running Clippy, namely:

```
$ cargo clippy --all-targets --workspace --all-features
warning: this function has too many arguments (8/7)
    --> lib/pdm-client/src/lib.rs:1093:5
     |
1093 | /     pub async fn pve_list_storages(
1094 | |         &self,
1095 | |         remote: &str,
1096 | |         node: &str,
...    |
1101 | |         target: Option<String>,
1102 | |     ) -> Result<Vec<StorageInfo>, Error> {
     | |________________________________________^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
     = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: `pdm-client` (lib) generated 1 warning
warning: `pdm-client` (lib test) generated 1 warning (1 duplicate)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s
```

Maximiliano Sandoval (7):
  remove needless borrows
  simplify if-else block
  remote tasks: remove unneeded enclosing Ok() and ?
  firewall: prefer is_some_and over map_or false
  subscription: remove unneeded return statement
  api: resources: collapse identical if blocks
  api: resources: rewrite let-else block with ?

 cli/admin/src/remotes.rs                      |  2 +-
 cli/client/src/subscriptions.rs               |  2 +-
 server/src/api/nodes/sdn.rs                   |  2 +-
 server/src/api/nodes/subscription.rs          |  2 +-
 server/src/api/pve/firewall.rs                |  2 +-
 server/src/api/remote_shell.rs                |  4 +--
 server/src/api/resources.rs                   | 29 +++++++++----------
 server/src/auth/mod.rs                        |  2 +-
 .../tasks/remote_tasks.rs                     |  4 +--
 9 files changed, 23 insertions(+), 26 deletions(-)

-- 
2.47.3





More information about the pdm-devel mailing list