[pdm-devel] [RFC proxmox{, -datacenter-manager, -yew-comp} 0/8] make security groups expandable in firewall rules list

[Lukas Wagner]

On Tue Dec 9, 2025 at 5:45 PM CET, Hannes Laimer wrote:
> Thanks for the feedback! some comments inline
>
> On 12/9/25 16:23, Lukas Wagner wrote:
>> On Fri Dec 5, 2025 at 4:25 PM CET, Hannes Laimer wrote:
>>> This contains some rough edges, mostly UI wise, but I'd like to get some
>>> feedback on if we like this approach. Currently we don't really
>>> know what a security group actually contains, in the list currently it's
>>> a bit of a black box what a group actually does. Finding out what rules it
>>> contains is a little cumbersome. This should make that easier. It seemed
>>> like a good place too, I considerd an extra tab maybe. But especially
>>> for read-only I think this is better.
>> 
>> Yeah, I think approach could work. But I'd also be interested what other
>> think.
>> 
>> If we ever change the view so that rules are editable, I guess we could
>> keep it as is, but should probably keep the rules from the group
>> read-only in their expanded form. To edit the actual rules of the group,
>> some other form of UI would be good, maybe like you suggested, in a
>> separate tab on the 'Datacenter'/'Remote' level.
>
> Since rules in groups are just rules so technically editing isn't a
> problem, but yes, might be a little confusing cause it would edit the
> rule for all instances where the group is used...
>
> maybe some "reduced editing" could also make sense, maybe just order and
> on/off, but that's a not relevant for this
>

Yeah, I think the main issue with allowing edits would be indeed the
confusion that this would affect other guests/hosts as well, that could
be quite a surprise.