[pdm-devel] [PATCH datacenter-manager/proxmox v2 0/7] fix #6914: add option to remove already existing token

Shan Shaji s.shaji at proxmox.com
Wed Dec 10 17:37:29 CET 2025


If a user removed a remote without deleting its associated token,
PDM would not allow re-adding the same remote unless the token
was changed. To fix this, support for optionally deleting the token
from the remote has been added.

This patch series adds support to delete the token using an optional
boolean flag in CLIs ie. on both admin and client. Additionaly, also
added a check box inside the UI that allow users to choose whether to 
delete the token while removing the remote.

History
=======
patch: https://lore.proxmox.com/pdm-devel/DETUIY1JX929.1PHFNA7IHWJZ5@proxmox.com/T/#t

changes since v1:
- Locked the remote config inorder to avoid race condition. Thanks @Michael
- Included missing admin cli implementation. Thanks @Michael
- Addressed nit comments. Thanks @Shannon

proxmox-datacenter-manager:

Shan Shaji (6):
  server: pbs-client: add delete admin token method
  server: api: add support to optionally delete token from remote
  pdm-client: accept `delete-token` argument for deleting api token
  cli: client: add `delete-token` option to delete token from remote
  fix: ui: add remove confirmation dialog with optional token deletion
  cli: admin: add `delete-token` option to delete token from remote

 cli/admin/src/remotes.rs        |  20 ++++--
 cli/client/src/remotes.rs       |  11 ++-
 lib/pdm-client/src/lib.rs       |  11 ++-
 server/src/api/remotes.rs       |  46 ++++++++++++-
 server/src/pbs_client.rs        |   7 ++
 ui/src/remotes/config.rs        |  38 ++++++++---
 ui/src/remotes/mod.rs           |   2 +
 ui/src/remotes/remove_remote.rs | 117 ++++++++++++++++++++++++++++++++
 8 files changed, 231 insertions(+), 21 deletions(-)
 create mode 100644 ui/src/remotes/remove_remote.rs


proxmox:

Shan Shaji (1):
  pve-api-types: generate missing `delete_token` method

 pve-api-types/generate.pl           |  1 +
 pve-api-types/src/generated/code.rs | 11 +++++++++++
 2 files changed, 12 insertions(+)


Summary over all repositories:
  10 files changed, 243 insertions(+), 21 deletions(-)

-- 
Generated by git-murpp 0.8.1




More information about the pdm-devel mailing list