[pdm-devel] applied: [PATCH datacenter-manager v1] ui: remote wizard: fix "invalid uri character" when adding PBS remote

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Dec 9 17:43:54 CET 2025


On Wed, 03 Dec 2025 20:17:11 +0100, Max R. Carrara wrote:
> ... by normalizing the hostname in the form context directly when the
> user clicks on "Next" in the remote addition wizard.
> 
> This is necessary because the wizard takes the values for submission
> directly from its form context.
> 
> This is somewhat easy to run into, e.g. if one copy-pastes the URL of
> the PBS remote to add from another browser tab.
> 
> [...]

Applied, thanks!

btw. might be also nice to extend normalize_hostname such that it also
removes hash anchor parts from the URL, as those are also often there if one
copies the full URL from the address bar of a PBS or PVE's web UI browser
tab.

FWIW, there is a web APIs to pare an URL [0], so it might be sensible to use
that API if the URL starts with `https?://` and get the host (hostname +
port) from there rather than continuing to heuristically strip away parts.

[0]: https://developer.mozilla.org/en-US/docs/Web/API/URL/parse_static

[1/1] ui: remote wizard: fix "invalid uri character" when adding PBS remote
      commit: ca5a7957af2be8110d4a1052a60e10606f22e498




More information about the pdm-devel mailing list