[pdm-devel] applied: [PATCH proxmox-datacenter-manager v7 00/24] metric collection improvements (concurrency, API, CLI)

[Thomas Lamprecht]

On Tue, 26 Aug 2025 15:50:55 +0200, Lukas Wagner wrote:
> Key points:
> - fetch metrics concurrently
> - Add some tests for the core logic in the metric collection system
> - Allow to trigger metric collection via the API
> - Record metric collection statistics in the RRD
>   - overall collection time for all remotes
>   - per remote response time when fetching metrics
> - Persist metric collection state to disk:
>   /var/lib/proxmox-datacenter-manager/metric-collection-state.json
>   (timestamps of last collection, errors)
> - Trigger metric collection for any new remotes added via the API
> 
> [...]

Applied, thanks!

[01/24] metric collection: split top_entities split into separate module
        commit: 538fc07e95c39ee643c1c8498361e3592e3f42d0
[02/24] metric collection: save metric data to RRD in separate task
        commit: 633cada6b3e1d8e86a0e91c8e89bac6a3e9ea5db
[03/24] metric collection: rework metric poll task
        commit: 397574e3073e37351d01eed6ac363fcf8e571d15
[04/24] metric collection: persist state after metric collection
        commit: 4b9468fee556aabcb446f38fa86e1b737de565b1
[05/24] metric collection: skip if last_collection < MIN_COLLECTION_INTERVAL
        commit: 8ba70d487a8f0b5489fb489cf92431e1c42f056a
[06/24] metric collection: collect overdue metrics on startup/timer change
        commit: 28268ed6e318ef21001e68ceb1f381e83ea19d6a
[07/24] metric collection: add tests for the fetch_remotes function
        commit: 64dfe3fc69632dc7a546ccfba3ff35296dd9e50e
[08/24] metric collection: add test for fetch_overdue
        commit: b5aa756b9730290c5e37d33dd97a9468f14ec408
[09/24] metric collection: pass rrd cache instance as function parameter
        commit: 14c93fa2909946824a9b08d26e1eab7b7aa53ef6
[10/24] metric collection: add test for rrd task
        commit: 80aa0071966eb8f7b7f770d9d942a380419ca452
[11/24] metric collection: wrap rrd_cache::Cache in a struct
        commit: 497c5d7efc3d1e165d9ee8aef5a32f066db19a74
[12/24] metric collection: record remote response time in metric database
        commit: 235a79507a06588e0173c48090a342a1f93575d6
[13/24] metric collection: save time needed for collection run to RRD
        commit: e160d4ed2bc2d6ec5dba48697d6729ee9192e11b
[14/24] metric collection: periodically clean removed remotes from statefile
        commit: ed18c8388a21a3df98c939546dba5c4bcfa15961
[15/24] api: add endpoint to trigger metric collection
        commit: e3a6bccdea013ad5f1f2756d818f38d541d810eb
[16/24] api: remotes: trigger immediate metric collection for newly added nodes
        commit: 51f93b45bc6aa1873d00df709b4a7645ec134345
[17/24] api: add api for querying metric collection RRD data
        commit: 9b01a3822a80490e6c830f613d5c0fbe5a4a958b
[18/24] api: metric-collection: add status endpoint
        commit: 07e2cdf2bc10521d4d2608596a6e44a9c728024b
[19/24] pdm-client: add metric collection API methods
        commit: ae60329b68c57b7820be680861b914dd38458b45
[20/24] cli: add commands for metric-collection trigger and status
        commit: 7b37bbe1a2ba3cae243779fc833357f42bc92229
[21/24] metric collection: skip missed timer ticks
        commit: 7030ad0a8ff011d8eb40af4e95e20b5c5210d60a
[22/24] metric collection: use JoinSet instead of joining from handles in a Vec
        commit: 075002688de2f7062ebf1333e7f5b266ed55ff44
[23/24] metric collection: allow to wait until completion when triggering collection manually
        commit: 1f9cf78be132a2004b15ce944df2dff648b4bf7d
[24/24] api: pve: rrd: trigger and wait for metric collection when requesting RRD data
        commit: a6df09b101d5f091f4f5a9058f99ae364629916a