[pdm-devel] [PATCH network/proxmox{, -backup, -api-types, -datacenter-manager} 00/32] Add initial SDN / EVPN integration

[Dominik Csapak]

all in all the series looks already very good to me, i had some comments
(see the individual replies)

on a higher level, the most "controversial" thing that's most likely
to fail is IMHO the locking across multiple remotes

the current approach leaves the sdn locked on the respective remotes
where e.g. an apply fails, but i don't think we have a good way
out of there without falling back to the command line?

(this is probably a general problem with the sdn locking, no?)

for now falling back to the cli can be good enough for me at the moment,
we should soon try to make at least the most common issues fixable
from the gui (be it on pdm side or pve side)

in any case we should give the user a hint in the task log what
to do on a failure, e.g. linking to the relevant documentation/wiki page

the backend part looks fine to me, maybe someone else might want
to take a look, the gui parts had some comments from me


all patches that did not get an individual reply can be
considered

Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>