[pdm-devel] [PATCH datacenter-manager v4 00/23] improve remote wizard

[Lukas Wagner]

On Fri Aug 22, 2025 at 10:32 AM CEST, Dominik Csapak wrote:
> # Summary
>
> This series improves the remote wizard in various points:
> * improved wording and texts
> * moved seperate buttons on pages into the next button
> * probing of entered nodes
> * confirmation dialog for missing fingerprints
> * better realm selector
>
> ## Probing on the server side
>
> I tried to determine if we need a fingerprint for nodes inside the
> API call, by probing each node. Since we currently only get the
> nodenames and not FQDNs in the nodelist, this will currently not
> result in a valid connection in most cases and return the fingerprint.
>
> My plan would be to include FQDNs of the nodes on the PVE side API call,
> so we can return here a list of nodename, ip and FQDNs, which the user
> then can select from. (which of those I'd probe on first check is yet
> to be determined)
>
> # Future work
>
> The next step for the wizard is to have some kind of quick copy&paste
> info. After discussing off-list with Fabian a bit, I think it would be
> best for this to contain the hostname (FQDN?) + fingerprint (if just a
> self-signed certificate) + a list of nodes with their respective
> nodename + FQDNs (maybe requires api change on PVE side to generate
> this). The user would then still have to do most of the steps currently
> necessary in the wizard, except the manual copy & pasting of
> fingerprints and maybe entering of FQDNs.
>
> changes from v3:
> * fixed outdated doc comments
> * disable realm selector when using a token directly
> * only rescan host / for nodes whent he previous form changed

Looks good to me now:

Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>
Tested-by: Lukas Wagner <l.wagner at proxmox.com>