[pdm-devel] [PATCH datacenter-manager 0/3] add rrd time frame selector for pve panels

[Dominik Csapak]

On 8/18/25 14:30, Lukas Wagner wrote:
> On Fri Jun 6, 2025 at 2:10 PM CEST, Dominik Csapak wrote:
>> this series adds an rrd time frame selector to qemu/lxc/node panels for
>> pve.
>>
>> note that my recent series[0] for improving the rrd graphs should be
>> applied first, otherwise there are some situations where the yew
>> application can easily panic.
>>
>> 0: https://lore.proxmox.com/yew-devel/20250530122202.2779300-1-d.csapak@proxmox.com/T/#t
>>
>> Dominik Csapak (3):
>>    ui: pve: qemu: add rrd time frame selector
>>    ui: pve: lxc: add rrd time frame selector
>>    ui: pve: nodes: add rrd time frame selector
>>
>>   ui/src/pve/lxc.rs  | 26 ++++++++++++++++++--------
>>   ui/src/pve/node.rs | 33 ++++++++++++++++++++++-----------
>>   ui/src/pve/qemu.rs | 26 ++++++++++++++++++--------
>>   3 files changed, 58 insertions(+), 27 deletions(-)
> 
> Looks good to me.
> 
> Reviewed-by: Lukas Wagner <l.wagner at proxmox.com>
> Tested-by: Lukas Wagner <l.wagner at proxmox.com>
> 
> (I can apply these if you want, but I didn't so far since I'm not
> familiar at all with the UI code yet)
> 

imo you can apply it, but we must bump the yew-comp dependency to 0.5.6
(which is just being uploaded), otherwise we can easily generate panics 
when switching between the ranges