[pdm-devel] superseded: [PATCH proxmox-datacenter-manager] api: priv-api: admin-cli: use new logger builder
Lukas Wagner
l.wagner at proxmox.com
Fri Apr 11 14:12:39 CEST 2025
On 2025-04-11 13:39, Gabriel Goller wrote:
> On 11.04.2025 13:32, Lukas Wagner wrote:
>> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
>> ---
>>
>> Notes:
>> The Logger::tasklog_pbs is actually not specific to PBS but should be
>> used for anything that uses WorkerTasks with a LogContext, as far as I
>> can tell. We might want to rename it at some point.
>
> Maybe we could put the first sentence here inside the commit message?
>
> Otherwise LGTM!
>
> Consider:
> Reviewed-by: Gabriel Goller <g.goller at proxmox.com>
>
>> [snip]
Good point actually, sent a v2 with the amended commit message, included your
R-b along the way.
Superseded-by: https://lore.proxmox.com/all/20250411121028.265555-1-l.wagner@proxmox.com/T/#u
--
- Lukas
More information about the pdm-devel
mailing list