[pdm-devel] applied: [PATCH datacenter-manager] server/ui: don't return token secret in api response
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Dec 19 13:15:49 CET 2024
Am 19.12.24 um 13:03 schrieb Dominik Csapak:
> as a stop-gap, simply return the empty string for the secret.
> Later we can fix that up with a proper type e.g. like we do in
> proxmox-backup with `RemoteWithoutPassword`, but that touches too many
> places here currently, so this seems fine for now.
>
> On the UI side it's enough to simply don't mark it required and
> add a placeholder. If its empty, it won't get submitted anyway.
>
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> server/src/api/remotes.rs | 8 ++++++--
> ui/src/remotes/edit_remote.rs | 3 ++-
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
>
applied, thanks!
More information about the pdm-devel
mailing list