[pbs-devel] [PATCH proxmox 00/10] Bump edition to 2024

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Jan 26 16:13:37 CET 2026


This allows clippy and rustfmt to find more venues for chore commits.

Some of these changes can be commited. rustfmt.toml is added so that rebasing is
simplified to dropping the last commit and running fmt again.

After commenting the following tests which fail due to permission errors:

- test_replace_file
- test_replace_file_with_dir
- test_replace_dir_with_file
- test_whiteout_dead_symlink_parent
- test_whiteout_current_directory
- test_whiteout_symlink

$ cargo test --workspace --all-features --all-targets

passes.

Maximiliano Sandoval (10):
  adapt to rust 2024 match ergonomics
  rustfmt: Set style_edition to 2021
  cargo: set workspace edition to 2024
  cargo: run fmt
  cargo: set resolver to 3
  cargo: run --fix
  cargo: run fmt again
  Remove rustfmt.toml and run cargo fmt
  cargo: run fmt with 2024 style
  pve-api-types: specify rustfmt --edition 2024

 Cargo.toml                                    |   6 +-
 pbs-api-types/src/acl.rs                      |   4 +-
 pbs-api-types/src/ad.rs                       |   4 +-
 pbs-api-types/src/crypto.rs                   |   2 +-
 pbs-api-types/src/datastore.rs                |  18 +--
 pbs-api-types/src/jobs.rs                     |  17 ++-
 pbs-api-types/src/ldap.rs                     |   5 +-
 pbs-api-types/src/lib.rs                      |  22 ++--
 pbs-api-types/src/maintenance.rs              |  12 +-
 pbs-api-types/src/metrics.rs                  |   2 +-
 pbs-api-types/src/openid.rs                   |   2 +-
 pbs-api-types/src/pathpatterns.rs             |   2 +-
 pbs-api-types/src/percent_encoding.rs         |   2 +-
 pbs-api-types/src/tape/changer.rs             |   2 +-
 pbs-api-types/src/tape/drive.rs               |   6 +-
 pbs-api-types/src/tape/media_location.rs      |   2 +-
 pbs-api-types/src/tape/media_pool.rs          |   2 +-
 pbs-api-types/src/tape/mod.rs                 |   4 +-
 pbs-api-types/src/traffic_control.rs          |   2 +-
 pbs-api-types/src/user.rs                     |   4 +-
 pbs-api-types/src/version.rs                  |   2 +-
 proxmox-access-control/src/acl.rs             |  29 +++--
 proxmox-access-control/src/api/acl.rs         |   6 +-
 proxmox-access-control/src/api/tokens.rs      |   6 +-
 proxmox-access-control/src/init.rs            |   6 +-
 proxmox-access-control/src/token_shadow.rs    |   6 +-
 proxmox-access-control/src/types.rs           |   6 +-
 proxmox-access-control/src/user.rs            |   4 +-
 proxmox-acme-api/src/account_config.rs        |   4 +-
 proxmox-acme-api/src/acme_plugin.rs           |   2 +-
 proxmox-acme-api/src/certificate_helpers.rs   |   6 +-
 proxmox-acme-api/src/lib.rs                   |   2 +-
 proxmox-acme-api/src/plugin_api_impl.rs       |   8 +-
 proxmox-acme-api/src/plugin_config.rs         |   8 +-
 proxmox-acme-api/src/types.rs                 |   2 +-
 proxmox-acme/src/account.rs                   |   2 +-
 proxmox-acme/src/async_client.rs              |   4 +-
 proxmox-acme/src/authorization.rs             |   2 +-
 proxmox-acme/src/eab.rs                       |   2 +-
 proxmox-acme/src/jws.rs                       |   2 +-
 proxmox-acme/src/key.rs                       |   2 +-
 proxmox-acme/src/order.rs                     |   2 +-
 proxmox-api-macro/src/api/enums.rs            |  24 ++--
 proxmox-api-macro/src/api/method.rs           |  70 +++++------
 proxmox-api-macro/src/api/mod.rs              |   2 +-
 proxmox-api-macro/src/api/structs.rs          |   4 +-
 proxmox-api-macro/src/serde.rs                |  10 +-
 proxmox-api-macro/src/util.rs                 |  46 ++++---
 proxmox-api-macro/tests/allof.rs              |   2 +-
 proxmox-api-macro/tests/api1.rs               |   2 +-
 proxmox-api-macro/tests/ext-schema.rs         |   2 +-
 proxmox-api-macro/tests/options.rs            |   2 +-
 proxmox-api-macro/tests/updater.rs            |   2 +-
 proxmox-apt-api-types/src/lib.rs              |   2 +-
 proxmox-apt/src/api.rs                        |   2 +-
 proxmox-apt/src/cache.rs                      |  12 +-
 proxmox-apt/src/cache_api.rs                  |  10 +-
 proxmox-apt/src/deb822/mod.rs                 |   2 +-
 proxmox-apt/src/deb822/packages_file.rs       |   2 +-
 proxmox-apt/src/deb822/release_file.rs        |  12 +-
 proxmox-apt/src/deb822/sources_file.rs        |   2 +-
 proxmox-apt/src/repositories/file.rs          |  16 +--
 .../src/repositories/file/list_parser.rs      |  12 +-
 .../src/repositories/file/sources_parser.rs   |   2 +-
 proxmox-apt/src/repositories/mod.rs           |   4 +-
 proxmox-apt/src/repositories/release.rs       |   2 +-
 proxmox-apt/src/repositories/repository.rs    |  10 +-
 proxmox-apt/tests/repositories.rs             |   6 +-
 proxmox-async/src/broadcast_future.rs         |   4 +-
 proxmox-async/src/io/async_channel_writer.rs  |   2 +-
 proxmox-auth-api/examples/passwd.rs           |   2 +-
 proxmox-auth-api/src/api/access.rs            |  14 +--
 proxmox-auth-api/src/api/mod.rs               |   8 +-
 proxmox-auth-api/src/api/ticket.rs            |   2 +-
 proxmox-auth-api/src/auth_key.rs              |   8 +-
 proxmox-auth-api/src/pam_authenticator.rs     |   4 +-
 .../src/password_authenticator.rs             |   2 +-
 proxmox-auth-api/src/ticket.rs                |   4 +-
 proxmox-auth-api/src/types.rs                 |   4 +-
 proxmox-base64/src/implementation.rs          |   2 +-
 proxmox-client/src/client.rs                  |   2 +-
 proxmox-compression/src/zip.rs                |   2 +-
 proxmox-compression/src/zstd.rs               |   2 +-
 proxmox-compression/tests/zip.rs              |   2 +-
 proxmox-config-digest/src/lib.rs              |  12 +-
 proxmox-daemon/src/command_socket.rs          |   2 +-
 proxmox-daemon/src/server.rs                  |   6 +-
 proxmox-daemon/src/state.rs                   |   6 +-
 proxmox-dns-api/src/api_types.rs              |   4 +-
 proxmox-dns-api/src/resolv_conf.rs            |   2 +-
 proxmox-docgen/src/lib.rs                     |   2 +-
 proxmox-http-error/src/lib.rs                 |   2 +-
 proxmox-http/src/body.rs                      |   4 -
 proxmox-http/src/client/connector.rs          |   4 +-
 proxmox-http/src/client/simple.rs             |  10 +-
 proxmox-http/src/client/tls.rs                |  30 ++---
 proxmox-http/src/proxy_config.rs              |   2 +-
 proxmox-http/src/rate_limited_stream.rs       |   2 +-
 proxmox-http/src/uri.rs                       |   2 +-
 proxmox-http/src/websocket/mod.rs             |   6 +-
 proxmox-human-byte/src/lib.rs                 |   2 +-
 proxmox-io/src/lib.rs                         |   2 +-
 proxmox-lang/src/lib.rs                       |   4 +-
 proxmox-ldap/src/lib.rs                       |   2 +-
 proxmox-ldap/src/sync.rs                      |  17 ++-
 proxmox-ldap/src/types.rs                     |   5 +-
 proxmox-ldap/tests/glauth.rs                  |  15 +--
 proxmox-log/src/builder.rs                    |   8 +-
 proxmox-log/src/file_logger.rs                |   2 +-
 proxmox-log/src/lib.rs                        |   2 +-
 proxmox-log/src/tasklog_layer.rs              |   6 +-
 proxmox-metrics/src/influxdb/http.rs          |   2 +-
 proxmox-metrics/src/influxdb/utils.rs         |   2 +-
 proxmox-metrics/src/lib.rs                    |   2 +-
 proxmox-network-api/src/api_impl.rs           |   8 +-
 proxmox-network-api/src/api_types.rs          |   4 +-
 proxmox-network-api/src/config/helper.rs      |   2 +-
 proxmox-network-api/src/config/lexer.rs       |   4 +-
 proxmox-network-api/src/config/mod.rs         |   8 +-
 proxmox-network-api/src/config/parser.rs      |   4 +-
 proxmox-network-types/src/ip_address.rs       | 116 +++++++++++-------
 proxmox-network-types/src/mac_address.rs      |   2 +-
 proxmox-node-status/src/api.rs                |   2 +-
 proxmox-node-status/src/lib.rs                |   2 +-
 proxmox-notify/src/api/gotify.rs              |  46 +++----
 proxmox-notify/src/api/matcher.rs             |  22 ++--
 proxmox-notify/src/api/sendmail.rs            |  36 +++---
 proxmox-notify/src/api/smtp.rs                |  46 +++----
 proxmox-notify/src/api/webhook.rs             |  33 ++---
 proxmox-notify/src/config.rs                  |  18 +--
 proxmox-notify/src/context/mod.rs             |   2 +-
 proxmox-notify/src/context/pbs.rs             |   4 +-
 proxmox-notify/src/context/pve.rs             |   4 +-
 proxmox-notify/src/context/test.rs            |   2 +-
 proxmox-notify/src/endpoints/gotify.rs        |   4 +-
 proxmox-notify/src/endpoints/sendmail.rs      |   4 +-
 proxmox-notify/src/endpoints/smtp.rs          |  10 +-
 proxmox-notify/src/endpoints/webhook.rs       |   6 +-
 proxmox-notify/src/lib.rs                     |   4 +-
 proxmox-notify/src/matcher.rs                 |   4 +-
 proxmox-notify/src/renderer/mod.rs            |   2 +-
 proxmox-oci/src/lib.rs                        |   6 +-
 proxmox-oci/src/oci_tar_image.rs              |   2 +-
 proxmox-oci/tests/extract_replace.rs          |   2 +-
 proxmox-oci/tests/extract_whiteouts.rs        |   2 +-
 proxmox-openid/src/auth_state.rs              |   6 +-
 proxmox-openid/src/lib.rs                     |  16 +--
 proxmox-rate-limiter/src/rate_limiter.rs      |   2 +-
 .../src/shared_rate_limiter.rs                |   6 +-
 proxmox-resource-scheduling/src/pve_static.rs |   6 +-
 proxmox-resource-scheduling/src/topsis.rs     |   2 +-
 proxmox-resource-scheduling/tests/topsis.rs   |   2 +-
 .../examples/minimal-rest-server.rs           |   6 +-
 proxmox-rest-server/src/api_config.rs         |  10 +-
 proxmox-rest-server/src/compression.rs        |   2 +-
 proxmox-rest-server/src/connection.rs         |  10 +-
 proxmox-rest-server/src/environment.rs        |   2 +-
 proxmox-rest-server/src/formatter.rs          |   2 +-
 proxmox-rest-server/src/h2service.rs          |   2 +-
 proxmox-rest-server/src/lib.rs                |   2 +-
 proxmox-rest-server/src/rest.rs               |   8 +-
 proxmox-rest-server/src/worker_task.rs        |   6 +-
 proxmox-rest-server/tests/worker_task.rs      |   4 +-
 proxmox-router/src/cli/command.rs             |  14 +--
 proxmox-router/src/cli/completion.rs          |   2 +-
 proxmox-router/src/cli/completion_helpers.rs  |   2 +-
 proxmox-router/src/cli/format.rs              |   6 +-
 proxmox-router/src/cli/mod.rs                 |   2 +-
 proxmox-router/src/cli/shellword.rs           |   2 +-
 proxmox-router/src/cli/text_table.rs          |   2 +-
 proxmox-router/src/error.rs                   |   2 +-
 proxmox-router/src/format.rs                  |   2 +-
 proxmox-router/src/permission.rs              |  10 +-
 proxmox-router/src/router.rs                  |  74 ++++++-----
 proxmox-router/src/stream/parsing.rs          |   9 +-
 proxmox-rrd/examples/prrd.rs                  |  10 +-
 proxmox-rrd/src/cache.rs                      |   8 +-
 proxmox-rrd/src/cache/journal.rs              |  24 ++--
 proxmox-rrd/src/cache/rrd_map.rs              |   2 +-
 proxmox-rrd/src/rrd.rs                        |   4 +-
 proxmox-rrd/tests/file_format_test.rs         |   2 +-
 proxmox-s3-client/src/api_types.rs            |   2 +-
 proxmox-s3-client/src/aws_sign_v4.rs          |   2 +-
 proxmox-s3-client/src/client.rs               |   8 +-
 proxmox-s3-client/src/lib.rs                  |   2 +-
 proxmox-s3-client/src/object_key.rs           |   6 +-
 proxmox-s3-client/src/response_reader.rs      |  12 +-
 proxmox-s3-client/src/timestamps.rs           |   2 +-
 proxmox-schema/src/de/mod.rs                  |   6 +-
 proxmox-schema/src/de/no_schema.rs            |   2 +-
 proxmox-schema/src/format.rs                  |  18 +--
 proxmox-schema/src/property_string.rs         |  22 ++--
 proxmox-schema/src/schema.rs                  |  14 ++-
 proxmox-schema/src/upid.rs                    |   6 +-
 proxmox-schema/tests/schema_verification.rs   |   4 +-
 proxmox-section-config/src/lib.rs             |  16 +--
 proxmox-section-config/src/typed.rs           |  12 +-
 proxmox-sendmail/src/lib.rs                   |   4 +-
 proxmox-serde/src/json.rs                     |   2 +-
 proxmox-shared-cache/src/lib.rs               |   2 +-
 proxmox-shared-memory/src/lib.rs              |   2 +-
 proxmox-shared-memory/src/shared_mutex.rs     |   4 +-
 .../tests/raw_shared_mutex.rs                 |   2 +-
 proxmox-simple-config/src/lib.rs              |   2 +-
 proxmox-sortable-macro/src/lib.rs             |   2 +-
 proxmox-subscription/src/check.rs             |   6 +-
 proxmox-subscription/src/files.rs             |   8 +-
 proxmox-subscription/src/lib.rs               |   2 +-
 proxmox-subscription/src/sign.rs              |   2 +-
 proxmox-subscription/src/subscription_info.rs |  10 +-
 proxmox-sys/src/command.rs                    |   2 +-
 proxmox-sys/src/crypt.rs                      |   2 +-
 proxmox-sys/src/fd.rs                         |   4 +-
 proxmox-sys/src/fs/acl.rs                     |   2 +-
 proxmox-sys/src/fs/dir.rs                     |   4 +-
 proxmox-sys/src/fs/file.rs                    |   4 +-
 proxmox-sys/src/fs/mod.rs                     |   2 +-
 proxmox-sys/src/fs/read_dir.rs                |   2 +-
 proxmox-sys/src/linux/mod.rs                  |   2 +-
 proxmox-sys/src/linux/pid.rs                  |   2 +-
 proxmox-sys/src/linux/procfs/mod.rs           |   2 +-
 proxmox-sys/src/linux/procfs/mountinfo.rs     |   2 +-
 proxmox-sys/src/linux/tty.rs                  |   2 +-
 proxmox-sys/src/logrotate.rs                  |   6 +-
 proxmox-sys/src/macros.rs                     |   4 +-
 proxmox-sys/src/process_locker.rs             |   2 +-
 proxmox-sys/src/systemd.rs                    |   2 +-
 proxmox-systemd/src/journal.rs                |   2 +-
 proxmox-systemd/src/lib.rs                    |   2 +-
 proxmox-systemd/src/notify.rs                 |   2 +-
 proxmox-tfa/src/api/methods.rs                |   2 +-
 proxmox-tfa/src/api/mod.rs                    |  76 ++++++------
 proxmox-tfa/src/api/recovery.rs               |   2 +-
 proxmox-tfa/src/api/webauthn.rs               |  12 +-
 proxmox-tfa/src/totp.rs                       |   8 +-
 proxmox-tfa/src/u2f.rs                        |   6 +-
 proxmox-time-api/src/time_impl.rs             |   2 +-
 proxmox-time/src/calendar_event.rs            |   4 +-
 proxmox-time/src/daily_duration.rs            |   6 +-
 proxmox-time/src/parse_helpers.rs             |   2 +-
 proxmox-time/src/posix.rs                     |   2 +-
 proxmox-time/src/test.rs                      |   2 +-
 proxmox-time/src/time_span.rs                 |   2 +-
 proxmox-time/src/wasm.rs                      |   2 +-
 proxmox-time/src/week_days.rs                 |   2 +-
 proxmox-upgrade-checks/src/lib.rs             |   6 +-
 proxmox-uuid/src/lib.rs                       |   4 +-
 proxmox-worker-task/src/lib.rs                |   2 +-
 pve-api-types/generate.pl                     |   4 +-
 pve-api-types/src/types/array.rs              |  18 +--
 pve-api-types/src/types/mod.rs                |   6 +-
 pve-api-types/src/types/verifiers.rs          |  15 +--
 rustfmt.toml                                  |   1 -
 253 files changed, 935 insertions(+), 893 deletions(-)
 delete mode 100644 rustfmt.toml

-- 
2.47.3





More information about the pbs-devel mailing list