[pbs-devel] [PATCH v4 proxmox-backup 02/11] datastore: remove Arc<ChunkStore> from FixedIndexWriter
Christian Ebner
c.ebner at proxmox.com
Mon Jan 26 11:47:39 CET 2026
On 1/23/26 4:42 PM, Robert Obkircher wrote:
> The ChunkStore reference can be safely removed, because it was only
> needed for the base directory. As discussed previously in the context
> of the DynamicIndexWriter [1], it is the callers responsibility to
> ensure that the writer doesn't outlive any locks.
>
> This simplifies testing the writer, which would otherwise require a
> workaround to avoid taking 3 seconds to create 65k directories.
>
> [1] https://lore.proxmox.com/pbs-devel/1761822027.sm41v71zmk.astroid@yuna.none/
>
> Signed-off-by: Robert Obkircher <r.obkircher at proxmox.com>
Changes are fine!
However, please reorder this patch to the front (since this could
already have been applied) and include one for the DynamicIndexWriter as
well, so implementations remain consistent for both.
More information about the pbs-devel
mailing list