[pbs-devel] [PATCH proxmox{, -backup} v2 0/2] GC: log progress output for phase 2 S3 datastores

[Arthur Bied-Charreton]

On Wed, Jan 21, 2026 at 11:45:35AM +0100, Christian Ebner wrote:
> This patch series adds accounting for basic request statistics to
> the S3 client, and uses it to provide request count and average
> request time for phase 2 of garbage collection on S3 stores.
> 
> Logging for phase 2 is implemented using a rate limited logger
> implementation, to control the number of output lines and avoid
> log spamming, given that the total number of objects cannot be
> determined a-priori.
> 
> Output the number of processed chunks as well as to be removed
> object count and size, including the number of objects still pending
> a delete API call as stored in the delete list.
> 
> Changes since v1 (thanks @Fabian for feedback):
> - Switch from dedicated thread output for logging to the rate limited
>   logging implementation.
> - Extend logging output to include delete object accounting and
>   request statistics.
> 

Tested-by: Arthur Bied-Charreton <a.bied-charreton at proxmox.com>

I tested these changes on a local MinIO S3 datastore, the rate-limited
logging output appears at the expected intervals, and the request statistics 
are accurately displayed.

Just one question maybe: why is sequential consistency needed for the request 
counters? Wouldn't relaxed ordering be sufficient for statistics?