[pbs-devel] [PATCH proxmox{, -backup} 0/6] fix #6716: Add support for http proxy configuration for S3 endpoints

[Christian Ebner]

This patch series exposes the nodes proxy config setting to the S3
clients for datastores backed by an S3 object store.

To honor crate boundaries, the proxy configuration is not read when
instantiating the s3-client via the datastore backend directly,
but rather by passing in a callback function on datastore
instantiation, allowing to gather the current node proxy whenever a
new s3 client connection is being created.

To achieve this, the first patches of the series refactor the code
so the callback can be passed by wrapping into a convenience helper.

Testing was performed by proxying traffic using https://www.mitmproxy.org/

Link to the bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=6716

proxmox:

Christian Ebner (2):
  pbs-api-types: make operation non-optional for maintenance-mode check
  s3-client: add proxy configuration as optional client option

 pbs-api-types/src/maintenance.rs        |  6 +++---
 proxmox-s3-client/examples/s3_client.rs |  1 +
 proxmox-s3-client/src/client.rs         | 10 +++++++++-
 3 files changed, 13 insertions(+), 4 deletions(-)


proxmox-backup:

Christian Ebner (4):
  datastore: make operation non-optional in lookups
  tools: factor out node proxy config read helper
  datastore: refactor datastore lookup parameters into dedicated type
  fix #6716: pass node http proxy config to s3 backend

 pbs-datastore/src/datastore.rs              | 88 +++++++++++++++------
 pbs-datastore/src/lib.rs                    |  2 +-
 pbs-datastore/src/snapshot_reader.rs        | 20 +++--
 src/api2/admin/datastore.rs                 | 58 +++++++-------
 src/api2/admin/namespace.rs                 |  9 ++-
 src/api2/admin/s3.rs                        |  2 +
 src/api2/backup/mod.rs                      |  3 +-
 src/api2/config/datastore.rs                | 16 +++-
 src/api2/config/s3.rs                       | 11 ++-
 src/api2/node/apt.rs                        |  8 +-
 src/api2/reader/mod.rs                      |  3 +-
 src/api2/status/mod.rs                      |  6 +-
 src/api2/tape/backup.rs                     |  6 +-
 src/api2/tape/restore.rs                    |  6 +-
 src/bin/proxmox-backup-proxy.rs             |  8 +-
 src/server/metric_collection/mod.rs         |  2 +-
 src/server/prune_job.rs                     |  3 +-
 src/server/pull.rs                          |  7 +-
 src/server/push.rs                          |  3 +-
 src/server/verify_job.rs                    |  3 +-
 src/tape/pool_writer/new_chunks_iterator.rs | 15 ++--
 src/tools/mod.rs                            | 22 +++++-
 22 files changed, 203 insertions(+), 98 deletions(-)


Summary over all repositories:
  25 files changed, 216 insertions(+), 102 deletions(-)

-- 
Generated by git-murpp 0.8.1