[pbs-devel] [PATCH proxmox-backup 3/6] verify: never hold mutex lock in async scope on corrupt chunk rename

[Christian Ebner]

On 10/27/25 12:00 PM, Fabian Grünbichler wrote:
> On October 16, 2025 3:18 pm, Christian Ebner wrote:
>> Holding a mutex lock across async await boundaries is prone to
>> deadlock [0]. Renaming a corrupt chunk requires however async API
>> calls in case of datastores backed by S3.
>>
>> Fix this by simply not hold onto the mutex lock guarding the corrupt
>> chunk list during chunk verification tasks when calling the rename
>> method. If the chunk is already present in this list, there will be
>> no other verification task operating on that exact chunk anyways.
>>
>> [0] https://docs.rs/tokio/latest/tokio/sync/struct.Mutex.html#which-kind-of-mutex-should-you-use
>>
>> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> 
> please send this one as patch #1, it fixes a bug and is independent from
> the rest of the cleanup, AFAICT?

Yes, will be up-front in the v2.