[pbs-devel] [PATCH proxmox-backup 3/3] ui: add 'unmount-on-done' field to SyncJobEdit window

[Shannon Sterz]

On Tue Oct 14, 2025 at 1:53 PM CEST, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
>  www/window/SyncJobEdit.js | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 14ffddcd..00e6ed2e 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -122,6 +122,7 @@ Ext.define('PBS.window.SyncJobEdit', {
>                      }
>                      if (!me.isCreate) {
>                          PBS.Utils.delete_if_default(values, 'run-on-mount', false);
> +                        PBS.Utils.delete_if_default(values, 'unmount-on-done', false);
>                          PBS.Utils.delete_if_default(values, 'rate-in');
>                          PBS.Utils.delete_if_default(values, 'rate-out');
>                          PBS.Utils.delete_if_default(values, 'remote');
> @@ -499,8 +500,30 @@ Ext.define('PBS.window.SyncJobEdit', {
>                                  'Run this job when a relevant removable datastore gets mounted.',
>                              ),
>                          },
> +                        listeners: {
> +                            change: function (field, runOnMount) {
> +                                let me = this;
> +                                let view = me.up('pbsSyncJobEdit');
> +                                let unmountOnDoneCb = view.down('field[name=unmount-on-done]');
> +                                unmountOnDoneCb.setDisabled(!runOnMount);
> +                            },
> +                        },
> +                        uncheckedValue: false,
> +                        value: false,
> +                    },
> +                    {
> +                        xtype: 'proxmoxcheckbox',
> +                        name: 'unmount-on-done',
> +                        fieldLabel: gettext('Unmount when done'),
> +                        autoEl: {
> +                            tag: 'div',
> +                            'data-qtip': gettext(
> +                                'Unmount relevant removable datastore onmce sync job finishes.',

got a typo there: once, not onmce :)

> +                            ),
> +                        },
>                          uncheckedValue: false,
>                          value: false,
> +                        disabled: true,
>                      },
>                  ],
>              },