[pbs-devel] [PATCH proxmox-backup v2 6/6] api: admin: datastore: implement streaming content api call

[Thomas Lamprecht]

Am 09.10.25 um 11:03 schrieb Dominik Csapak:
> 
> anyway, i measured the peak RSS (directly from procfs) while these api
> calls were running:
> 
> for an old 'snapshot listing' with the same datastore as mentioned before, the peak usage was ~446MiB, while on the newer content
> streaming api (while streaming) was ~33MiB (which was about the
> same as before and after the api call)
> 
> so the memory usage for building the lists in memory takes about
> 446-32 ~414MiB (for about 600.000 snapshots)

Thanks for measuring, that difference looks quite nice!

> should i send a v3 with that info included? or should i wait
> for someone to do a more in depth review of the permissions?
> (AFAICS nobody wrote anything about that yet)

It's IMO fine to wait for another in-depth review (at least for the privs
checking), if this version is already good to go it would be great if the
maintainer pushing this would amend the numbers into the commit, but as
long as b4 is used we at least got a easy to follow link to this thread,