[pbs-devel] [PATCH proxmox-backup 6/6] api: admin: datastore: implement streaming content api call
Wolfgang Bumiller
w.bumiller at proxmox.com
Tue Oct 7 16:31:38 CEST 2025
On Tue, Oct 07, 2025 at 04:22:25PM +0200, Thomas Lamprecht wrote:
> Am 07.10.25 um 14:51 schrieb Wolfgang Bumiller:
> > And more reasons why [this][1] *really* needs at least *partial*
> > stabilization so we can switch to `Item` level imports. 🙄
> >
> > [1] https://github.com/rust-lang/rustfmt/issues/4991#issuecomment-3369792412
>
> In practice I'd prefer module level granularity though and instead
> question if crates like pbs-api-types really do need to re-export
> everything on a top-level instead of using actual modules there
They definitely do *not*.
> too. Which as a side effect then would also lessen the need for adding
> ThingListItem type names, which are IMO somewhat needed (or at least
> will always be something that devs go for) if we want to provide a
> single global type namespace.
Module level sounds nice in theory, and *could* look fine.
I'd definitely love undo the export mess we have, but as it is now,
module level imports_granularity would be an *absolute nightmare* for
our code base, while for Item level it wouldn't matter, it would produce
the least friction with git merges.
More information about the pbs-devel
mailing list