[pbs-devel] [PATCH proxmox-backup 2/2] datastore: gc: rename method and adapt incorrect comments
Christian Ebner
c.ebner at proxmox.com
Thu Oct 2 11:11:42 CEST 2025
ss the helper does not really mark the chunks but rather checks
if it should be added to the delete list.
Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
pbs-datastore/src/datastore.rs | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 2e62590f9..b76bb1987 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -1654,7 +1654,7 @@ impl DataStore {
for content in list_bucket_result.contents {
if self
- .mark_chunk_for_object_key(
+ .check_chunk_marker_for_object_key(
&content.key,
content.size,
min_atime,
@@ -1796,10 +1796,9 @@ impl DataStore {
Ok(())
}
- // Mark the chunk marker in the local cache store for the given object key as in use
- // by updating it's atime.
- // Returns Ok(true) if the chunk was updated and Ok(false) if the object was not a chunk.
- fn mark_chunk_for_object_key(
+ // Check if the chunk marker in the local cache store for the given object key marks the chunk
+ // object as in-use or adds it to the list of objects to delete.
+ fn check_chunk_marker_for_object_key(
&self,
object_key: &S3ObjectKey,
size: u64,
--
2.47.3
More information about the pbs-devel
mailing list