[pbs-devel] [PATCH proxmox v2] login: use `ticket` if both it and `ticket_info` are provided

[Christian Ebner]

On 10/1/25 3:11 PM, Shannon Sterz wrote:
> previously the precense of `ticket_info` was assumed to indicate the
> HTTPOnly authentication flow. the `ticket` field was ignore in that
> case, because the client has no way of validating a ticket anyway.
> 
> this commit changes the behaviour to assume that the server is not
> trying to "trick us" and that the presence of a `ticket` field
> indicates that this value should be used for authentication. if the
> `ticket_info` field is also present, it will be ignored.
> 
> this fixes an issue where authentication against later versions of
> proxmox-backup-server 3.4 failed. including versions up to and
> including version 3.4.6-1.
> 
> Signed-off-by: Shannon Sterz <s.sterz at proxmox.com>
> ---

Only one question: Should the `SecondFactorChallenge::response_bytes()` 
also prioritize `ticket`  over `ticket_info` to get the same flow behavior?

Other than that the changes look good to me, as they do follow the same 
intend of parsing the full ticket I did try
to force via the compat mode in 
https://lore.proxmox.com/pdm-devel/DD70FPP8GIBO.2K8CWBW5XPL0K@proxmox.com/T/

Tested ticket parsing and request authentication works with this patch 
applied by using PDM remote add wizard (which uses the proxmox-login) 
for the following version:
- PBS 3.4.0 (fresh install from ISO), 3.4.6, 4.0.11 (fresh install from 
ISO), 4.0.15
- PVE 8.4.0 (fresh install from ISO), 8.4.14, 9.0.3 (fresh install from 
ISO), 9.0.10

Please consider:

Reviewed-by: Christian Ebner <c.ebner at proxmox.com>
Tested-by: Christian Ebner <c.ebner at proxmox.com>