[pbs-devel] applied: [PATCH proxmox-backup v2] fix #6566: backup: api: conditionally drop group and snapshot locks

Fabian Grünbichler f.gruenbichler at proxmox.com
Wed Oct 1 10:59:05 CEST 2025


On Mon, 29 Sep 2025 17:17:59 +0200, Christian Ebner wrote:
> To guarantee consistency by possible concurrent operations, the
> backup protocol locks the backup group, the previous backup
> snapshot (if any) and holds a lock for the newly created backup
> snapshot. All of these are currently stored in the backup worker
> task, only released on its destruction.
> 
> The backup API however signals a successful backup via the return
> status of the `finish` call, while still holding the locks.
> Therefore, an immediate subsequent backup of the client to the same
> group can fail because the locks cannot be acquired until the previous
> backup task is completely destroyed, which can however outlive the
> `finish` return for some time. This manifests in e.g. a push sync job
> failing.
> 
> [...]

Applied, thanks!

[1/1] fix #6566: backup: api: conditionally drop group and snapshot locks
      commit: b1ece6c70c7785191321525576ed6f53e9c4bc18

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler at proxmox.com>




More information about the pbs-devel mailing list