[pbs-devel] [PATCH proxmox-backup v2 5/6] ui: verify: fetch default {read, verify} thread values from tuning options

[Nicolas Frey]

making sure that the now default (e.g. emptyText) value matches the
one found at the datastore-tuning level, we fetch the tuning data
and bind it to the respective `emptyText` properties.

Reviewed-by: Christian Ebner <c.ebner at proxmox.com>
Tested-by: Christian Ebner <c.ebner at proxmox.com>
Signed-off-by: Nicolas Frey <n.frey at proxmox.com>
---
 www/window/VerifyAll.js     | 38 +++++++++++++++++++++++++++++++++++--
 www/window/VerifyJobEdit.js | 37 ++++++++++++++++++++++++++++++++++++
 2 files changed, 73 insertions(+), 2 deletions(-)

diff --git a/www/window/VerifyAll.js b/www/window/VerifyAll.js
index 4239c215..c0fae10b 100644
--- a/www/window/VerifyAll.js
+++ b/www/window/VerifyAll.js
@@ -11,6 +11,36 @@ Ext.define('PBS.window.VerifyAll', {
         url: `/admin/datastore/{datastore}/verify`,
     },
 
+    viewModel: {
+        data: {
+            defaultReadThreads: null,
+            defaultVerifyThreads: null,
+        },
+    },
+
+    initComponent: function () {
+        let me = this;
+        me.callParent();
+
+        if (me.datastore === undefined) {
+            return;
+        }
+
+        Proxmox.Utils.API2Request({
+            url: `/api2/extjs/config/datastore/${encodeURIComponent(me.datastore)}`,
+            method: 'GET',
+            success: ({ result }) => {
+                let raw = result?.data?.tuning || {};
+                let tuning = PBS.Utils.parsePropertyString(raw);
+
+                me.getViewModel().set({
+                    defaultReadThreads: tuning['default-verification-readers'] ?? 1,
+                    defaultVerifyThreads: tuning['default-verification-workers'] ?? 4,
+                });
+            },
+        });
+    },
+
     submitText: gettext('Verify'),
     isCreate: true,
     showTaskViewer: true,
@@ -84,7 +114,9 @@ Ext.define('PBS.window.VerifyAll', {
                     xtype: 'proxmoxintegerfield',
                     name: 'read-threads',
                     fieldLabel: gettext('# of Read Threads'),
-                    emptyText: '1',
+                    bind: {
+                        emptyText: '{defaultReadThreads}',
+                    },
                     skipEmptyText: true,
                     minValue: 1,
                     maxValue: 32,
@@ -93,7 +125,9 @@ Ext.define('PBS.window.VerifyAll', {
                     xtype: 'proxmoxintegerfield',
                     name: 'verify-threads',
                     fieldLabel: gettext('# of Verify Threads'),
-                    emptyText: '4',
+                    bind: {
+                        emptyText: '{defaultVerifyThreads}',
+                    },
                     skipEmptyText: true,
                     minValue: 1,
                     maxValue: 32,
diff --git a/www/window/VerifyJobEdit.js b/www/window/VerifyJobEdit.js
index 5650ed5c..93396a4d 100644
--- a/www/window/VerifyJobEdit.js
+++ b/www/window/VerifyJobEdit.js
@@ -32,8 +32,38 @@ Ext.define('PBS.window.VerifyJobEdit', {
     viewModel: {
         data: {
             ignoreVerified: true,
+            defaultReadThreads: null,
+            defaultVerifyThreads: null,
         },
     },
+
+    loadThreadDefaults: function (datastore) {
+        Proxmox.Utils.API2Request({
+            url: `/api2/extjs/config/datastore/${encodeURIComponent(datastore)}`,
+            method: 'GET',
+            success: ({ result }) => {
+                let raw = result?.data?.tuning || {};
+                let tuning = PBS.Utils.parsePropertyString(raw);
+
+                this.getViewModel().set({
+                    defaultReadThreads: tuning['default-verification-readers'] ?? 1,
+                    defaultVerifyThreads: tuning['default-verification-workers'] ?? 4,
+                });
+            },
+        });
+    },
+
+    initComponent: function () {
+        let me = this;
+        me.callParent();
+
+        if (me.datastore === undefined) {
+            return;
+        }
+
+        me.loadThreadDefaults(me.datastore);
+    },
+
     controller: {
         xclass: 'Ext.app.ViewController',
         control: {
@@ -46,6 +76,7 @@ Ext.define('PBS.window.VerifyJobEdit', {
             let view = this.getView();
             let nsSelector = view.down('pbsNamespaceSelector');
             nsSelector.setDatastore(value);
+            view.loadThreadDefaults(value)
         },
     },
 
@@ -164,6 +195,9 @@ Ext.define('PBS.window.VerifyJobEdit', {
                 cbind: {
                     deleteEmpty: '{!isCreate}',
                 },
+                bind: {
+                    emptyText: '{defaultReadThreads}',
+                },
             },
             {
                 xtype: 'proxmoxintegerfield',
@@ -175,6 +209,9 @@ Ext.define('PBS.window.VerifyJobEdit', {
                 cbind: {
                     deleteEmpty: '{!isCreate}',
                 },
+                bind: {
+                    emptyText: '{defaultVerifyThreads}',
+                },
             },
         ],
         advancedColumn2: [
-- 
2.47.3