[pbs-devel] [PATCH proxmox 1/5] proxmox-upgrade-checks: fix meta package version check

Shannon Sterz s.sterz at proxmox.com
Mon Nov 24 10:56:39 CET 2025


On Mon Nov 24, 2025 at 10:54 AM CET, Shannon Sterz wrote:
> On Thu Nov 20, 2025 at 4:08 PM CET, Stefan Hanreich wrote:
>> On 11/20/25 4:03 PM, Shannon Sterz wrote:
>>> ah thanks for catching this, i somehow missed this, i'll need to ping my
>>> series finally switching pdm over to this crate again. anyhow, for now
>>> this is fine, though i would appreciate this approach a bit more:
>>>
>>> ```
>>>         if let Some(old_version) = meta_pkg.and_then(|m| m.old_version.as_ref()) {
>>>             let pkg_version = Regex::new(r"^(\d+)\.(\d+)[.-](\d+)")?;
>>>             let captures = pkg_version.captures(old_version);
>>> ```
>>
>> yeah, this seems indeed better - Idk why I always default to map over
>> and_then in such cases :P

as discussed off-list i'll adapt this patch as outlined here and add it
to my series trying to factor out the upgrading checking logic so we
can unify it.





More information about the pbs-devel mailing list