[pbs-devel] [PATCH proxmox-backup 3/3] GC: S3: phase2: delete last partial batch of objects at the very end

[Christian Ebner]

While going trough the rest of the series in detail now, one idea right 
away.

On 11/21/25 10:06 AM, Fabian Grünbichler wrote:
> instead of after every processing every batch of 1000 listed objects. this
> reduces the number of delete calls made to the backend, making regular garbage
> collections that do not delete most objects cheaper, but means holding the
> flocks for garbage chunks/objects longer.

We could avoid holding the flock for to long (e.g. GC over several days 
because of super slow local datastore cache, S3 backend, ...) by setting 
(or resetting) a timer on each last delete list insert, and not only 
using the batch size to decide if to perform the deleteObjects() call, 
but rather compare if a timeout has been elapsed.

This would safeguard us from locking some chunks way to long, causing 
potential issues with concurrent backups, but not trow out all the 
benefits this patch brings.

What do you think? I could send that as followup if you like.