[pbs-devel] superseded: [PATCH proxmox-backup] task tracking: improve pruning of reused-PID stale entries
Hannes Laimer
h.laimer at proxmox.com
Thu Nov 20 07:05:06 CET 2025
superseded-by:
https://lore.proxmox.com/pbs-devel/20251120060245.21828-1-h.laimer@proxmox.com/T/#u
On 11/17/25 09:57, Hannes Laimer wrote:
> Keep entries only when check_process_running(pid) reports a
> starttime equal to the stored one. This improves pruning of stale
> entries for all PIDs (not just the current one) and aligns update
> with the read path. Counting behavior and semantics are unchanged.
>
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
> noticed while looking through recent proposed changes to the tracking
> logic. this isn't a problem, but should keep the tracking file cleaner
> and remove a match arm in the code
>
> pbs-datastore/src/task_tracking.rs | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/pbs-datastore/src/task_tracking.rs b/pbs-datastore/src/task_tracking.rs
> index 44a4522d..4fcbbaa4 100644
> --- a/pbs-datastore/src/task_tracking.rs
> +++ b/pbs-datastore/src/task_tracking.rs
> @@ -114,8 +114,7 @@ pub fn update_active_operations(
> .iter_mut()
> .filter_map(
> |task| match procfs::check_process_running(task.pid as pid_t) {
> - Some(stat) if pid == task.pid && stat.starttime != task.starttime => None,
> - Some(_) => {
> + Some(stat) if stat.starttime == task.starttime => {
> if pid == task.pid {
> found_entry = true;
> match operation {
More information about the pbs-devel
mailing list