[pbs-devel] partially-applied: [PATCH proxmox-backup v2 0/6] wait for active operations to finish before s3 refresh

[Fabian Grünbichler]

On Wed, 12 Nov 2025 17:36:18 +0100, Christian Ebner wrote:
> Datastore contents located on the s3 backend can be refreshed on the local
> datastore cache by running an s3-refresh, which will set the maintenance mode
> s3-refresh to block any read/write operation and fetch the contents to a
> temporary directory before moving them in place if the fetching was successful.
> 
> Setting the maintenance mode has however no effect on already active operations,
> which can cause inconsistencies once the s3 refresh moves the temporary folders
> in place.
> 
> [...]

Applied the first two patches, thanks!

[1/6] api: datastore: fix typo in helper function name
      commit: acfa4a59ee1a97feabdf7c2e4e2ec046274d45d4
[2/6] api: admin: make expected maintenance type helper generic over type
      commit: 0eb02a15e33f70431ddad6867a96a277062962e2

Left the following for a v3 with minor feedback:

[3/6] api: admin: factor out busy waiting on active operations
      (no commit info)
[4/6] api: admin: factor out locking and maintenance mode clearing
      (no commit info)
[5/6] datastore: s3 refresh: set/unset maintenance mode in api handler
      (no commit info)
[6/6] api: datastore: wait for active operations to clear before s3 refresh
      (no commit info)

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler at proxmox.com>