[pbs-devel] superseded: [PATCH proxmox{, -backup} v2 0/5] unmount datastores after sync job

[Hannes Laimer]

superseded-by: 
https://lore.proxmox.com/pbs-devel/20251112120515.145480-1-h.laimer@proxmox.com/T/#t

On 10/29/25 17:01, Hannes Laimer wrote:
> Adds the option to automatically unmount a datastore after a sync job
> finishes.
> 
> The idea is that, in combination with run-on-mount, it is possible to
> have datastores sync to external drives without the need to open the web
> ui or terminal. This came up a handful of times in support and a recent
> thread on the forum. Basically, also non-tech people could be tasked
> with plugging and unplugging different drives regularly and mounting,
> sync and unmounting would be done automatically.
> 
> Currently if any of the triggered jobs have the 'unmount-on-done' flag
> set the datastore will be unmounted right after the last of the
> triggered jobs finishes.
> 
> This seemed pretty straight forward and should be good in most use-cases
> I came up with. Also, I did consider having 'unmount-on-done' also for
> normally(schedule/manual) started jobs, I guess there could be some
> situations where that might useful. But, as I mentioned on the commit
> itself, we'd probably have to go through the command socket since sync jobs run
> on the proxy. And I did not think it adds that much, also not sure if
> we'd even want that.
> 
> Tested-by: Robert Obkircher <r.obkircher at proxmox.com>
> 
> v2, thanks @Robert and @Shannon
>   - include short docs section
>   - fix typo
>   - fix test
>   - use `|=` (instead of `= ... || ...`)
> 
> proxmox:
> 
> Hannes Laimer (1):
>    pbs-api-types: add 'unmount-on-done' field to sync job config
> 
>   pbs-api-types/src/jobs.rs | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> 
> proxmox-backup:
> 
> Hannes Laimer (4):
>    api: syncjob: correctly update/delete 'unmount-on-done' field
>    api: datastore: unmount datastore after sync if configured
>    ui: add 'unmount-on-done' field to SyncJobEdit window
>    docs: add section about `unmount-on-done`
> 
>   docs/managing-remotes.rst   |  4 ++++
>   src/api2/admin/datastore.rs | 21 +++++++++++++++++++--
>   src/api2/config/sync.rs     |  9 +++++++++
>   www/window/SyncJobEdit.js   | 23 +++++++++++++++++++++++
>   4 files changed, 55 insertions(+), 2 deletions(-)
> 
> 
> Summary over all repositories:
>    5 files changed, 63 insertions(+), 2 deletions(-)
>