[pbs-devel] [PATCH proxmox{, -backup} v3 0/5] unmount datastores after sync job

[Hannes Laimer]

Adds the option to automatically unmount a datastore after a sync job
finishes.

The idea is that, in combination with run-on-mount, it is possible to
have datastores sync to external drives without the need to open the web
ui or terminal. This came up a handful of times in support and a recent
thread on the forum. Basically, also non-tech people could be tasked
with plugging and unplugging different drives regularly and mounting,
sync and unmounting would be done automatically.

Currently if any of the triggered jobs have the 'unmount-on-done' flag
set the datastore will be unmounted right after the last of the
triggered jobs finishes.

This seemed pretty straight forward and should be good in most use-cases
I came up with.


v3, thanks @Fabian:
 - pull logic for unmounting out of endpoint so we can easily use the
   function directly instead of going through the API
 - add validation to sync job update endpoint, only allow
   unmount_on_done to be set if run_on_mount is set
 - unmounting now done by caller
 - improve commit message

v2, thanks @Robert and @Shannon
 - include short docs section
 - fix typo
 - fix test
 - use `|=` (instead of `= ... || ...`)


proxmox:

Hannes Laimer (1):
  pbs-api-types: add 'unmount-on-done' field to sync job config

 pbs-api-types/src/jobs.rs | 9 +++++++++
 1 file changed, 9 insertions(+)


proxmox-backup:

Hannes Laimer (4):
  api: syncjob: correctly update/delete 'unmount-on-done' field
  api: datastore: auto-unmount after mount-triggered sync
  ui: add 'unmount-on-done' field to SyncJobEdit window
  docs: add section about `unmount-on-done`

 docs/managing-remotes.rst   |  4 ++
 src/api2/admin/datastore.rs | 96 ++++++++++++++++++++++---------------
 src/api2/config/sync.rs     | 12 +++++
 www/window/SyncJobEdit.js   | 26 ++++++++++
 4 files changed, 99 insertions(+), 39 deletions(-)


Summary over all repositories:
  5 files changed, 108 insertions(+), 39 deletions(-)

-- 
Generated by git-murpp 0.8.1